Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on TreeItem's cell modes #92112

Merged

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented May 19, 2024

TreeItem's various cell modes has lots of quirks and hidden functionality. This PR attempts to document some of it.
My favorite Tree feature is when you assign a text to a slider, it magically becomes a dropdown.

I noticed some overall inconsistencies in the Tree/Item documentation, like descriptions referring to column, while I think it should say "cell". Also many descriptions are somewhat lacking, because most methods are specific to a single cell mode, or if used in multiple modes, they might have different effect depending on mode. I did not attempt to fix it all though.

@KoBeWi KoBeWi added this to the 4.3 milestone May 19, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner May 19, 2024 10:44
@KoBeWi KoBeWi force-pushed the is_there_something_this_class_can't_do branch from b26dd92 to d33d2b5 Compare May 19, 2024 10:54
doc/classes/TreeItem.xml Outdated Show resolved Hide resolved
doc/classes/TreeItem.xml Outdated Show resolved Hide resolved
doc/classes/TreeItem.xml Outdated Show resolved Hide resolved
doc/classes/TreeItem.xml Outdated Show resolved Hide resolved
@KoBeWi KoBeWi force-pushed the is_there_something_this_class_can't_do branch from d33d2b5 to a541d45 Compare May 19, 2024 12:15
@akien-mga akien-mga merged commit b082225 into godotengine:master May 20, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the is_there_something_this_class_can't_do branch May 20, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants